Skip to content

Change functions params order in the Groth16VerifierHelper library #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

Change functions params order in the Groth16VerifierHelper library #134

merged 1 commit into from
Feb 27, 2025

Conversation

Hrom131
Copy link
Member

@Hrom131 Hrom131 commented Feb 25, 2025 •
edited
Loading

  • Since this PR suggests a bug fix, the tests have been added and the coverage is 100%.
  • Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
  • This PR is just a minor change, like a typo fix.

@Hrom131 Hrom131 requested a review from Arvolear February 25, 2025 16:43
@codecov Codecov
Copy link

codecov bot commented Feb 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (70a5c0a) to head (ebc8aab).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          57       57           
  Lines        3404     3404           
  Branches      459      382   -77     
=======================================
  Hits         3402     3402           
  Misses          2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Arvolear
Arvolear approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@Arvolear Arvolear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arvolear Arvolear merged commit ced3f5e into master Feb 27, 2025
4 checks passed
@Arvolear Arvolear deleted the fix/params_order branch February 27, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arvolear Arvolear Arvolear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hrom131 @Arvolear